Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change mismatch threshold for lenient profile #291

Closed
wants to merge 1 commit into from

Conversation

hextraza
Copy link
Contributor

@hextraza hextraza commented Aug 9, 2024

I checked to see if we were getting antisense hits that shouldn't be contaminating the results for LILRB3, and it seems like only the expected orientations are being let through. I'm adding a flag to optionally report antisense hits as a separate feature rather than discarding them. The vast majority of the reads in the nimble-only subset I sent you (i.e. that aren't placed in the expected location despite getting called for the feature) get filtered out if we lower the gap size, so I'd like to try that. It could be worth doing something in NimbleAlignPanel.js to make that value configurable per job but at the moment based on what I'm seeing from the subset data, this would solve most of the noisiness issues with LILRB3 and STAT3, alongside with a bugfix I made in the aligner.

@bbimber
Copy link
Contributor

bbimber commented Aug 9, 2024

Hey, you wrote:

"The vast majority of the reads in the nimble-only subset I sent you (i.e. that aren't placed in the expected location despite getting called for the feature) get filtered out if we lower the gap size, so I'd like to try that. It could be worth doing something in NimbleAlignPanel.js to make that value configurable per job"

Is gap_size it's own parameter? I am pretty sure the parameter you're changing here is already configurable per job, isnt it? See here:

@hextraza hextraza closed this Aug 12, 2024
@bbimber bbimber deleted the 24.7_fb_lowerNimbleLenientMismatch branch September 8, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants