Change mismatch threshold for lenient profile #291
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I checked to see if we were getting antisense hits that shouldn't be contaminating the results for LILRB3, and it seems like only the expected orientations are being let through. I'm adding a flag to optionally report antisense hits as a separate feature rather than discarding them. The vast majority of the reads in the nimble-only subset I sent you (i.e. that aren't placed in the expected location despite getting called for the feature) get filtered out if we lower the gap size, so I'd like to try that. It could be worth doing something in NimbleAlignPanel.js to make that value configurable per job but at the moment based on what I'm seeing from the subset data, this would solve most of the noisiness issues with LILRB3 and STAT3, alongside with a bugfix I made in the aligner.