Constrain popup dialog height in JBrowse #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbimber
force-pushed
the
24.7_fb_jbscroll
branch
from
414ce16 to
ad249d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This link should repro this: http://localhost:8080/home/jbrowse-browser.view?session=mgap
I posted the question to JBrowse and apparently this does not happen in all cases. This link shows their browser, which does overflow/scroll appropriately: https://jbrowse.org/storybook/lgv/main/?path=/story/source-code-for-examples--one-linear-genome-view
Also some discussion here: GMOD/jbrowse-components#4604 (comment). Their devs are good at questions and may have pointers if this is hard to investigate. I did not find the code in jbrowse itself that creates the Dialog, but I think we might need to find that to debug this.