-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 1.5.0 release branch #80
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new method on Dispatcher: addStore to support Flux#addStore Add tests for new api functionality New: Remove misleading comments in favor of descriptive variable naming New: Edit wording of error messages for clarity Signed-off-by: Brandon Tilley <[email protected]>
In general improve logic around handling of addAction(s)
Conflicts: lib/store.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additions/Non-Breaking Changes
addStore
,addStores
,addAction
, andaddActions
(Add ability to dynamically modify actions and stores in Flux instances #68, Modular api to satisfy #68 #71, Fleshing out add actions/stores API and docs #77)Flux
instances are now EventEmitters, and emit a"dispatch"
event (withtype
andpayload
arguments) when an action callsthis.dispatch(type, payload)
, useful for cross-cutting concerns like loggingStore#bindActions
now takes a hash (similar to the staticactions
hash) in addition to an argument list (Allow passing hash tobindActions
#51, Allow hash parameter to bindActions #78)bindActions
is falsy)Deprecations
Fluxxor.FluxChildMixin
is now deprecated; instead, useFluxMixin
anywhere you want access togetFlux()
(#59)