Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make parser unambiguous #28

Open
jakobnissen opened this issue May 27, 2020 · 2 comments
Open

Make parser unambiguous #28

jakobnissen opened this issue May 27, 2020 · 2 comments

Comments

@jakobnissen
Copy link
Member

See BioJulia/Automa.jl#48

The parsers in GeneticVariation.jl are ambiguous, and will break if BioJulia/Automa.jl#49 gets pushed. Importantly, it means that even if the PR is not pushed, it's currently possible to create inputs where the parser will take unexpected actions.

I can take a look at the parser some other day, if necessary. If you want to play around with it yourself, get the version of Automa in the PR linked above, then try it out.

@TransGirlCodes
Copy link
Member

The VCF parser in this package should be moved to a VCF.jl in line with the other parsers like FASTX, so depending on time it may be better to fix it as part of that work, unless it's urgent.

@jakobnissen
Copy link
Member Author

Not urgent, I don't use VCF files in my work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants