Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Half star doesn't work after upgrading to Angular v16 #128

Open
1 task
duxor opened this issue Jan 16, 2024 · 0 comments
Open
1 task

Half star doesn't work after upgrading to Angular v16 #128

duxor opened this issue Jan 16, 2024 · 0 comments

Comments

@duxor
Copy link
Contributor

duxor commented Jan 16, 2024 •
edited
Loading

Half star doesn't work after upgrading to Angular v16,
[this] change breaks the logic related to half star showing - [check the logic].

Minimal reproduction of the problem with instructions

I added workaround as well:

https://stackblitz.com/edit/stackblitz-starters-vn2jtb?file=src%2Fmain.ts

Versions

  • @angular/core: 17.0.0
  • rxjs: 7.8.0
  • angular-star-rating: 7.0.0
  • css-star-rating: 1.3.1

Browser name and version:

  • Chrome (desktop) version any
duxor pushed a commit to duxor/angular-star-rating that referenced this issue Jan 17, 2024
fix: remove default value of getHalfStarVisible to avoid bugs related…
0d7cc28 
… to half star logic BioPhoton#128
@duxor duxor mentioned this issue Jan 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@duxor