Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving BCO relations to RO #105

Open
ramonawalls opened this issue Feb 26, 2020 · 4 comments
Open

Consider moving BCO relations to RO #105

ramonawalls opened this issue Feb 26, 2020 · 4 comments

Comments

@ramonawalls
Copy link
Collaborator

ROBOT says it is an error to have our own relations. See http://obo-dashboard-test.ontodev.com/bco/fp7.html. We could request those in RO.

Row IRI Label Issue
1 http://purl.obolibrary.org/obo/BCO_0000058 has role shares label with http://purl.obolibrary.org/obo/RO_0000087
2 http://purl.obolibrary.org/obo/BCO_0000085 to taxon not an RO property
3 http://purl.obolibrary.org/obo/BCO_0000086 of organism not an RO property
4 http://purl.obolibrary.org/obo/BCO_0000087 member of taxon not an RO property
@ramonawalls
Copy link
Collaborator Author

Definitely we need to get rid of has role. That was just there because there were conflicts between RO:has role and some other has role, which I think has been fixed.

@bpeters42
Copy link

Hi Ramona: Only the definition of properties that have the same labels as an existing RO relation is considered an error. The other reports are intended to be warnings. It is understood that many ontologies will have their own relationships - it is more of a reminder to think about if any of the relations you are coining might be of more general use, and/or to inspect if there are overlapping properties in RO that could serve the same purpose.

@ramonawalls
Copy link
Collaborator Author

I am going to break these out into separate issues for each relation. I will close this issue once has role is deprecated.

@ramonawalls
Copy link
Collaborator Author

See #113 for to taxon and of organism.

member of taxon is okay as is for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants