Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate cropping into the same code paths #70

Open
multimeric opened this issue Aug 23, 2024 · 0 comments
Open

Integrate cropping into the same code paths #70

multimeric opened this issue Aug 23, 2024 · 0 comments

Comments

@multimeric
Copy link
Collaborator

Currently we have two entirely different code paths for cropping and non-cropping workflow. However, we could reduce a lot of code, and simplify maintenance by not doing this:

if self.cropping_enabled:
return ImageSlices(
lattice_data=self,
slices=self._process_crop()
)
else:
return ImageSlices(
lattice_data=self,
slices=self._process_non_crop()
)

This isn't a high priority, but just wanted to note it down somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant