From c4d04652a54468fb328de78e1af5fd437049c1aa Mon Sep 17 00:00:00 2001
From: James Duong <james.duong@improving.com>
Date: Sun, 26 Nov 2023 07:00:00 -0800
Subject: [PATCH] Do not use dependency analyze when compiling plugins

It is not correctly getting skipped.
---
 .../module-info-compiler-maven-plugin/pom.xml | 22 -------------------
 java/maven/pom.xml                            | 22 -------------------
 2 files changed, 44 deletions(-)

diff --git a/java/maven/module-info-compiler-maven-plugin/pom.xml b/java/maven/module-info-compiler-maven-plugin/pom.xml
index 6cd72edb095b3..ce598fc7f0f87 100644
--- a/java/maven/module-info-compiler-maven-plugin/pom.xml
+++ b/java/maven/module-info-compiler-maven-plugin/pom.xml
@@ -101,28 +101,6 @@
       </plugins>
     </pluginManagement>
     <plugins>
-      <plugin>
-        <groupId>org.apache.maven.plugins</groupId>
-        <artifactId>maven-dependency-plugin</artifactId>
-        <executions>
-          <execution>
-            <id>analyze</id>
-            <phase>verify</phase>
-            <goals>
-              <goal>analyze-only</goal>
-            </goals>
-            <configuration>
-              <!--
-                The dependency on org.glavo.module-info-compile is incorrectly
-                being reported as unused when running the Windows 2022 CI agent only.
-                Ignoring this dependency specifically is not happening on that agent either
-                so skip the plugin entirely.
-              -->
-              <skip>true</skip>
-            </configuration>
-          </execution>
-        </executions>
-      </plugin>
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-plugin-plugin</artifactId>
diff --git a/java/maven/pom.xml b/java/maven/pom.xml
index 3119fc341876b..86ac402732bc4 100644
--- a/java/maven/pom.xml
+++ b/java/maven/pom.xml
@@ -268,28 +268,6 @@
           <linkXRef>false</linkXRef>
         </configuration>
       </plugin>
-      <plugin>
-        <groupId>org.apache.maven.plugins</groupId>
-        <artifactId>maven-dependency-plugin</artifactId>
-        <executions>
-          <execution>
-            <id>analyze</id>
-            <phase>verify</phase>
-            <goals>
-              <goal>analyze-only</goal>
-            </goals>
-            <configuration>
-              <ignoreNonCompile>true</ignoreNonCompile>
-              <failOnWarning>true</failOnWarning>
-              <ignoredDependencies>
-                <!-- source annotations (not kept in compiled code) -->
-                <ignoredDependency>javax.annotation:javax.annotation-api:*</ignoredDependency>
-                <ignoredDependency>org.apache.hadoop:hadoop-client-api</ignoredDependency>
-              </ignoredDependencies>
-            </configuration>
-          </execution>
-        </executions>
-      </plugin>
       <plugin>
         <groupId>org.cyclonedx</groupId>
         <artifactId>cyclonedx-maven-plugin</artifactId>