Java: Add DUMP and RESTORE commands #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dump and Restore commands are currently not supported (blocked) in Transaction and related tests. |
tjzhang-BQ
reviewed
Jun 17, 2024
java/client/src/main/java/glide/api/commands/GenericBaseCommands.java
Outdated
Show resolved
Hide resolved
tjzhang-BQ
reviewed
Jun 17, 2024
java/client/src/main/java/glide/api/commands/GenericBaseCommands.java
Outdated
Show resolved
Hide resolved
tjzhang-BQ
reviewed
Jun 17, 2024
java/client/src/test/java/glide/api/ByteArrayArgumentMatcher.java
Outdated
Show resolved
Hide resolved
tjzhang-BQ
reviewed
Jun 17, 2024
tjzhang-BQ
reviewed
Jun 17, 2024
java/client/src/main/java/glide/api/commands/GenericBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/GenericBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/GenericBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/GenericBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/commands/RestoreOptions.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/commands/RestoreOptions.java
Outdated
Show resolved
Hide resolved
java/client/src/test/java/glide/api/ByteArrayArgumentMatcher.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/GenericBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/GenericBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/commands/RestoreOptions.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/commands/RestoreOptions.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/commands/RestoreOptions.java
Outdated
Show resolved
Hide resolved
- added custom setter methods for long values - changed seconds to idletime - minor comments updated
Yury-Fridlyand
approved these changes
Jun 19, 2024
java/client/src/main/java/glide/api/commands/GenericBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/GenericBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/GenericBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/commands/RestoreOptions.java
Outdated
Show resolved
Hide resolved
acarbonetto
reviewed
Jun 19, 2024
java/client/src/main/java/glide/api/commands/GenericBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/GenericBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/GenericBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/GenericBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/commands/RestoreOptions.java
Outdated
Show resolved
Hide resolved
acarbonetto
approved these changes
Jun 20, 2024
| } | ||
|
|
||
| /** Custom setter methods for replace and absttl */ | ||
| public static class RestoreOptionsBuilder { |
acarbonetto
pushed a commit
that referenced
this pull request
Jun 20, 2024
* Cherry-pick Java: Add DUMP and RESTORE commands * Fixed codestyle issues * Addressed review comments * Added more test to SharedCommandtests * Change ByteArrayArgumentMatcher to use Arrays.equals() comparison instead * Addressed review comments - added custom setter methods for long values - changed seconds to idletime - minor comments updated * Updated few minor comments * Removed Optional in RestoreOptions and added setter methods for replace and absttl
aaron-congo
pushed a commit
that referenced
this pull request
Jun 21, 2024
* Java: Add DUMP and RESTORE commands (#371) * Cherry-pick Java: Add DUMP and RESTORE commands * Fixed codestyle issues * Addressed review comments * Added more test to SharedCommandtests * Change ByteArrayArgumentMatcher to use Arrays.equals() comparison instead * Addressed review comments - added custom setter methods for long values - changed seconds to idletime - minor comments updated * Updated few minor comments * Removed Optional in RestoreOptions and added setter methods for replace and absttl * Replaced byte[] with GlideString and fixed codestyle issues * Updated comment in RestoreOptions.java * Addressed review comments * Addressed more review comments * Added the casting in handleBytesOrNullResponse to return byte[] * Removed unsed tempKey in SharedCommandTests Removed .getBytes() in RestoreOptions --------- Co-authored-by: Yi-Pin Chen <[email protected]>
cyip10
pushed a commit
that referenced
this pull request
Jun 24, 2024
* Java: Add DUMP and RESTORE commands (#371) * Cherry-pick Java: Add DUMP and RESTORE commands * Fixed codestyle issues * Addressed review comments * Added more test to SharedCommandtests * Change ByteArrayArgumentMatcher to use Arrays.equals() comparison instead * Addressed review comments - added custom setter methods for long values - changed seconds to idletime - minor comments updated * Updated few minor comments * Removed Optional in RestoreOptions and added setter methods for replace and absttl * Replaced byte[] with GlideString and fixed codestyle issues * Updated comment in RestoreOptions.java * Addressed review comments * Addressed more review comments * Added the casting in handleBytesOrNullResponse to return byte[] * Removed unsed tempKey in SharedCommandTests Removed .getBytes() in RestoreOptions --------- Co-authored-by: Yi-Pin Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://redis.io/docs/latest/commands/dump/
https://redis.io/docs/latest/commands/restore/