Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional NFT asset images #6

Open
ahdigital opened this issue Mar 16, 2021 · 4 comments
Open

Optional NFT asset images #6

ahdigital opened this issue Mar 16, 2021 · 4 comments

Comments

@ahdigital
Copy link

Should there be an optional token image, (avatar or thumbnail etc.) that a creator can specify?

Maybe brands would want to include their logo somewhere.

Or, using the art-o-matic POC as an example, my thinking is that whilst the list of artworks in the category looks good, what if the type is something else like music and you want to display an album cover.

@iamredbar
Copy link
Member

IMO that would depend on the viewer. If it is an art viewer, it will only look at assets with and image in the nft_object. The spec allows for different types of NFTs, but the details haven't been nailed down as to formats of other NFTs. Art is the lowest hanging fruit and the easiest to implement (besides maybe like prose or something)

@iamredbar
Copy link
Member

We also have to keep size constraints in mind to be good stewards of the network. We are trying to keep images to less than 30kb, so adding another thumbnail might go against that philosophy.
Could an art viewer site just render the art at a specific size for preview, then when expanding the image it displays fully?

@christophersanborn
Copy link
Member

Don't have any thoughts on this yet, but this is an interesting suggestion and discussion.

@grctest
Copy link

grctest commented Apr 10, 2021

Could always show the hashicon/robohash for the issuer's account as a fallback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants