Skip to content

Commit

Permalink
Merge pull request #13 from BitBagCommerce/OP-268/plugin_fixes
Browse files Browse the repository at this point in the history
[OP-268]Fix imoje notification resolving
  • Loading branch information
liszkapawel authored May 20, 2024
2 parents 0a670b3 + 5a3476f commit d14e2cd
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 7 deletions.
2 changes: 1 addition & 1 deletion src/Controller/NotifyController.php
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public function __construct(

public function verifyImojeNotification(Request $request): Response
{
if ('' !== $request->getContent()) {
if ('' === $request->getContent()) {
return new Response('', Response::HTTP_NO_CONTENT);
}

Expand Down
3 changes: 1 addition & 2 deletions tests/Application/.env
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,9 @@ MAILER_DSN=null://null
###< symfony/mailer ###

###> symfony/messenger ###
MESSENGER_TRANSPORT_DSN=doctrine://default
SYLIUS_MESSENGER_TRANSPORT_MAIN_DSN=doctrine://default
SYLIUS_MESSENGER_TRANSPORT_MAIN_FAILED_DSN=doctrine://default?queue_name=main_failed
SYLIUS_MESSENGER_TRANSPORT_CATALOG_PROMOTION_REMOVAL_DSN=doctrine://default?queue_name=catalog_promotion_removal
SYLIUS_MESSENGER_TRANSPORT_CATALOG_PROMOTION_REMOVAL_FAILED_DSN=doctrine://default?queue_name=catalog_promotion_removal_failed
###< symfony/messenger ###

MESSENGER_TRANSPORT_DSN=doctrine://default
1 change: 1 addition & 0 deletions tests/Application/.env.test
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ KERNEL_CLASS='Tests\BitBag\SyliusImojePlugin\Application\Kernel'

###> symfony/messenger ###
# Sync transport turned for testing env for the ease of testing
MESSENGER_TRANSPORT_DSN=sync://
SYLIUS_MESSENGER_TRANSPORT_MAIN_DSN=sync://
SYLIUS_MESSENGER_TRANSPORT_MAIN_FAILED_DSN=sync://
SYLIUS_MESSENGER_TRANSPORT_CATALOG_PROMOTION_REMOVAL_DSN=sync://
Expand Down
5 changes: 1 addition & 4 deletions tests/Application/composer.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
{
"name": "sylius/plugin-skeleton-test-application",
"description": "Sylius application for plugin testing purposes (composer.json needed for project dir resolving)",
"license": "MIT",
"require": {
"doctrine/annotations": "^1.14"
}
"license": "MIT"
}

0 comments on commit d14e2cd

Please sign in to comment.