Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to create wishlist using form submit in modal. #238

Closed
RickVdrongelen opened this issue Jan 18, 2024 · 2 comments
Closed

Unable to create wishlist using form submit in modal. #238

RickVdrongelen opened this issue Jan 18, 2024 · 2 comments

Comments

@RickVdrongelen
Copy link

When creating a wishlist using the modal, it sometimes happens that a user presses submits the form using the keyboard instead of pressing 'Perform' in the modal.
Since the form in the modal does not have action or a submit event handler, the form posts its action to /wishlist instead of /wishlist/create. This causes either a 422 Method not allowed error, but in most cases nothing happens.

Is there something i am missing or is this not yet implemented?

When it is not yet implemented, I believe this can fixed/implemented by doing the following.
Add either a action to the form in the modal to /wishlists/create. Or call the performAction javascript function when the form is submitted, instead of only handling the performAction function on the click event of the 'Perform' button.

Due to time constraints i am unable to submit a PR in the near future.

Thank for your time and this plugin.

@leszczuu
Copy link
Contributor

leszczuu commented Mar 8, 2024

should be fixed with #244

@RickVdrongelen
Copy link
Author

It works, and is running perfectly in a production environment. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants