Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup gtest incorporation #70

Open
MikeHopcroft opened this issue Nov 10, 2016 · 1 comment
Open

Cleanup gtest incorporation #70

MikeHopcroft opened this issue Nov 10, 2016 · 1 comment

Comments

@MikeHopcroft
Copy link
Contributor

The toplevel CMakeLists.txt still seems to have some holdovers from the time when we would clone gtest during configuration. These should be removed if we are not incorporating gtest via git subtree.
@danluu
Copy link
Contributor

danluu commented Nov 10, 2016

What's leftover? I took a look at this and it wasn't obvious to me what still needs to be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danluu @MikeHopcroft