Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Large number of clang warnings #71

Open
danluu opened this issue Nov 17, 2016 · 2 comments
Open

Large number of clang warnings #71

danluu opened this issue Nov 17, 2016 · 2 comments

Comments

@danluu
Copy link
Contributor

danluu commented Nov 17, 2016

We have so many warnings that if we enable general warnings the build errors out with "too many errors".

I've fixed some of these in 603d5fc and 5cc6904 but there are still a ton of these left.
@danluu
Copy link
Contributor Author

danluu commented Nov 17, 2016

I keep cleaning out the analogous warnings from BitFunnel, but now that we've integrated NativeJIT with BitFunnel it's going to be hard to stay warning clean without fixing these.

@danluu
Copy link
Contributor Author

danluu commented Jan 19, 2017

The next obvious warning to clean out is the precision loss / sign extension stuff. The last time I went through those I made some change that caused a subtle error that caused tests to fail. I don't really want to try this again unless our tests are clean and our tests have been failing on BitFunnel/BitFunnel#298 since Nov 2016. @MikeHopcroft has a proposed fix for this but I don't know what it is so this issue is blocked on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danluu