fix(eth-multisig-v4): add chain id of the coin in the network identifier

WIN-1423
BitGo · Dec 18, 2023 · 8efef00 · 8efef00
1 parent c6b91f2
commit 8efef00
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/contracts/coins/ArbethWalletSimple.sol b/contracts/coins/ArbethWalletSimple.sol
@@ -44,14 +44,14 @@ contract ArbethWalletSimple is WalletSimple {
    * This provides protection signatures being replayed on other chains
    */
   function getTokenNetworkId() internal override view returns (string memory) {
-    return string.concat(Strings.toString(block.chainid), 'ERC20');
+    return string.concat(Strings.toString(block.chainid), '-ERC20');
   }
 
   /**
    * Get the network identifier that signers must sign over for batch transfers
    * This provides protection signatures being replayed on other chains
    */
   function getBatchNetworkId() internal override view returns (string memory) {
-    return string.concat(Strings.toString(block.chainid), 'Batch');
+    return string.concat(Strings.toString(block.chainid), '-Batch');
   }
 }
diff --git a/contracts/coins/OpethWalletSimple.sol b/contracts/coins/OpethWalletSimple.sol
@@ -44,14 +44,14 @@ contract ArbethWalletSimple is WalletSimple {
    * This provides protection signatures being replayed on other chains
    */
   function getTokenNetworkId() internal override view returns (string memory) {
-    return string.concat(Strings.toString(block.chainid), 'ERC20');
+    return string.concat(Strings.toString(block.chainid), '-ERC20');
   }
 
   /**
    * Get the network identifier that signers must sign over for batch transfers
    * This provides protection signatures being replayed on other chains
    */
   function getBatchNetworkId() internal override view returns (string memory) {
-    return string.concat(Strings.toString(block.chainid), 'Batch');
+    return string.concat(Strings.toString(block.chainid), '-Batch');
   }
 }