From 8efef00c94197f5beebc4ff07f1a71d07107b814 Mon Sep 17 00:00:00 2001 From: Akash Gianchandani Date: Mon, 18 Dec 2023 18:21:35 +0530 Subject: [PATCH] fix(eth-multisig-v4): add chain id of the coin in the network identifier WIN-1423 --- contracts/coins/ArbethWalletSimple.sol | 4 ++-- contracts/coins/OpethWalletSimple.sol | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/contracts/coins/ArbethWalletSimple.sol b/contracts/coins/ArbethWalletSimple.sol index 5f62da3..0fe579c 100644 --- a/contracts/coins/ArbethWalletSimple.sol +++ b/contracts/coins/ArbethWalletSimple.sol @@ -44,7 +44,7 @@ contract ArbethWalletSimple is WalletSimple { * This provides protection signatures being replayed on other chains */ function getTokenNetworkId() internal override view returns (string memory) { - return string.concat(Strings.toString(block.chainid), 'ERC20'); + return string.concat(Strings.toString(block.chainid), '-ERC20'); } /** @@ -52,6 +52,6 @@ contract ArbethWalletSimple is WalletSimple { * This provides protection signatures being replayed on other chains */ function getBatchNetworkId() internal override view returns (string memory) { - return string.concat(Strings.toString(block.chainid), 'Batch'); + return string.concat(Strings.toString(block.chainid), '-Batch'); } } diff --git a/contracts/coins/OpethWalletSimple.sol b/contracts/coins/OpethWalletSimple.sol index 5e0ef7d..69462a9 100644 --- a/contracts/coins/OpethWalletSimple.sol +++ b/contracts/coins/OpethWalletSimple.sol @@ -44,7 +44,7 @@ contract ArbethWalletSimple is WalletSimple { * This provides protection signatures being replayed on other chains */ function getTokenNetworkId() internal override view returns (string memory) { - return string.concat(Strings.toString(block.chainid), 'ERC20'); + return string.concat(Strings.toString(block.chainid), '-ERC20'); } /** @@ -52,6 +52,6 @@ contract ArbethWalletSimple is WalletSimple { * This provides protection signatures being replayed on other chains */ function getBatchNetworkId() internal override view returns (string memory) { - return string.concat(Strings.toString(block.chainid), 'Batch'); + return string.concat(Strings.toString(block.chainid), '-Batch'); } }