Used the existing constants in BitGoJS.statics #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used constants in BitGoJs.statics in sign.js Removed const coinDecimals from sign.js and replaced with constants from BitGoJS.statics
|
Thanks @neharac8 -- appreciate you taking the time to tackle this issue. You're going to need to sign these commits (something we require being a crypto + fintech company focused on security). Some notes to help you do this: |
|
@neharac8 any chance of you signing these commits? We can merge this fairly trivially once you do 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Refactor all coins to fetch their constants from BitGoJS.statics.
Overview Of Changes
Removed const coinDecimals from sign.js and replaced with constants from BitGoJS.statics.
Fixes #61