Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ElectrumABC issue ledger #199

Closed
dokflide opened this issue Apr 29, 2022 · 7 comments
Closed

ElectrumABC issue ledger #199

dokflide opened this issue Apr 29, 2022 · 7 comments

Comments

@dokflide
Copy link

After updating electrumABC and apps on ledger live, ElectrumABC doesn't recognise any more my ledger.

@PiRK
Copy link
Collaborator

PiRK commented May 2, 2022

I'm investigating.
After upgrading apps and firmware in Ledger MAnager, my Ledger Nano X no longer working.

I'm getting the following error:


Traceback (most recent call last):
  File "/home/pierre/dev/ElectrumABC/electroncash_plugins/hw_wallet/qt.py", line 254, in run
    result = task.task()
  File "/home/pierre/dev/ElectrumABC/electroncash_plugins/ledger/ledger.py", line 685, in get_client
    client = devmgr.client_for_keystore(self, handler, keystore, force_pair)
  File "/home/pierre/dev/ElectrumABC/electroncash/plugins.py", line 879, in client_for_keystore
    client = self.force_pair_xpub(plugin, handler, info, xpub, derivation)
  File "/home/pierre/dev/ElectrumABC/electroncash/plugins.py", line 921, in force_pair_xpub
    client_xpub = client.get_xpub(derivation, xtype)
  File "/home/pierre/dev/ElectrumABC/electroncash_plugins/ledger/ledger.py", line 52, in catch_exception
    return func(self, *args, **kwargs)
  File "/home/pierre/dev/ElectrumABC/electroncash_plugins/ledger/ledger.py", line 106, in get_xpub
    self.checkDevice()
  File "/home/pierre/dev/ElectrumABC/electroncash_plugins/ledger/ledger.py", line 223, in checkDevice
    self.perform_hw1_preflight()
  File "/home/pierre/dev/ElectrumABC/electroncash_plugins/ledger/ledger.py", line 172, in perform_hw1_preflight
    firmwareInfo = self.dongleObject.getFirmwareVersion()
  File "/home/pierre/.local/lib/python3.10/site-packages/btchip/btchip.py", line 563, in getFirmwareVersion
    response = self.dongle.exchange(bytearray(apdu))
  File "/home/pierre/.local/lib/python3.10/site-packages/btchip/btchipComm.py", line 90, in exchange
    result = self.waitImpl.waitFirstResponse(timeout)
  File "/home/pierre/.local/lib/python3.10/site-packages/btchip/btchipComm.py", line 134, in waitFirstResponse
    data = self.device.read(65)
  File "hid.pyx", line 219, in hid.device.read
OSError: read error

@haplo
Copy link

haplo commented May 20, 2022

Upstream backwards-incompatible change?

LedgerHQ/btchip-python#52

@PiRK
Copy link
Collaborator

PiRK commented May 20, 2022

There is a (temporary?) fix in the 2.0.5 app LedgerHQ/app-bitcoin-new#36

@dokflide
Copy link
Author

dokflide commented May 20, 2022 via email

@PiRK
Copy link
Collaborator

PiRK commented May 20, 2022

I think we will have to wait until the new version of the app is available in Ledger Live, and then upgrade it. Yesterday it wasn't available, and I didn't check today.

@dokflide
Copy link
Author

dokflide commented May 21, 2022 via email

@PiRK
Copy link
Collaborator

PiRK commented May 25, 2022

A new version of the BCH app is available in Ledger Live (Ledger Manager) : 2.0.5
For me it solves the issue.

@PiRK PiRK closed this as completed May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants
@haplo @PiRK @dokflide and others