Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full screen/immersive mode #172

Open
b-risk opened this issue Jun 12, 2024 · 7 comments
Open

Full screen/immersive mode #172

b-risk opened this issue Jun 12, 2024 · 7 comments

Comments

@b-risk
Copy link

b-risk commented Jun 12, 2024

App leaves a gap for the camera hole and navigational bar on screen on my Pixel 6a.
Screenshot_20240612-172209_1

@rollerozxa
Copy link
Collaborator

How would you want it to look? Giving space for the cutout is intentional behaviour.

@b-risk
Copy link
Author

b-risk commented Jun 13, 2024

How would you want it to look? Giving space for the cutout is intentional behaviour.

Ideally I would like an option atleast to take up the entire screen without any blank space, I don't see a reason for the camera cutout area to be blank unless to make sure the button on the left isn't cut off but it makes it look inconsistent and off centered, if the button needs to not be in the same area as the camera cutout the space could still be used but both buttons could be moved towards the center of the screen (like how BTD6 handles it on mobile), and the navigation bar keeps an extra unneeded static image on screen.

@griffi-gh
Copy link
Contributor

griffi-gh commented Aug 6, 2024

This can be controlled in the Settings on some devices, like Samsung and Xiaomi (Check if your phone has an option like that.)
But the game makes no attempt to work around this (safe area is not checked), so this may look weird, especially on phones with larger (iphone-style) cutouts.

@rollerozxa
Copy link
Collaborator

On my phone the cutout width is more or less the same as the width for the navigation bar, making the game exactly centered. This is also the mode most other apps use to not have to deal with screen imperfections caused by camera cut-outs, notches and rounded screens.

Having the game adjust the UI to a safe area would be a nice setting to have but not worth the amount of effort to implement it personally. And if you're upset about the current state of phone screens then I am empathetic, but can't do much more than that. Fortunately they are large enough nowadays that padding the edges will still give you a sizable rendering area that is also at least 16:9 or wider.

@b-risk
Copy link
Author

b-risk commented Aug 6, 2024

This can be controlled in the Settings on some devices, like Samsung and Xiaomi (Check if your phone has an option like that.) But the game makes no attempt to work around this (safe area is not checked), so this may look weird, especially on phones with larger (iphone-style) cutouts.

This is indeed a possible solution I recognized but only for rooted devices and specific stock rom's, I use GrapheneOS I flashed on a Pixel phone for example which is a privacy and security rom based off AOSP (stock android with no proprietary modifications).

Having the game adjust the UI to a safe area would be a nice setting to have but not worth the amount of effort to implement it personally. And if you're upset about the current state of phone screens then I am empathetic, but can't do much more than that. Fortunately they are large enough nowadays that padding the edges will still give you a sizable rendering area that is also at least 16:9 or wider.

That would probably be the best solution to this by making the app adapt to newer layouts, but what I was trying to say was the game seems like it doesn't need extra blank space in the first place, atleast for phones with only a camera cutout (especially the navigation bar at the bottom screen, which seems to serve no purpose and is just distracting and could potentially cause damage to OLED screens). So if the devs don't want to spend time to adapt the game to newer phones what I suggested was atleast a toggle inside the settings of the app to give user's the choice to ignore the paddings depending how they want it to look on their phone, from a developer perspective and to my knowledge of this particular Android thing it does not seem hard to implement.

For reference this is how it would look on my phone with immersive mode enabled:
Untitled

@rollerozxa
Copy link
Collaborator

but what I was trying to say was the game seems like it doesn't need extra blank space in the first place

It does, both on the left side and the right side, because otherwise the UI will be cut off and you will have the navigational bar nagging you when pulling stuff out of the sandbox. If you want the UI to be cut off then you can override apps yourself to be in fullscreen mode as griffi-gh pointed out. We won't provide the option until the UI can properly account for screen safe areas (which will be whenever someone contributes it).

@b-risk
Copy link
Author

b-risk commented Aug 6, 2024

but what I was trying to say was the game seems like it doesn't need extra blank space in the first place

It does, both on the left side and the right side, because otherwise the UI will be cut off and you will have the navigational bar nagging you when pulling stuff out of the sandbox. If you want the UI to be cut off then you can override apps yourself to be in fullscreen mode as griffi-gh pointed out. We won't provide the option until the UI can properly account for screen safe areas (which will be whenever someone contributes it).

I do not have this proprietary OS override feature like I said, but yes in that case I might be wrong about that and I would also wait for the UI to be fully developed. I'll have to see if possibly I can contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants