Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bixal-site-drupal - bug: Cache tags not properly set for new accreditations #315

Open
mattsqd opened this issue Oct 21, 2024 · 1 comment
Labels
bug Something isn't working Drupal Requires integration from the Drupal side.

Comments

@mattsqd
Copy link
Collaborator

mattsqd commented Oct 21, 2024

Describe the bug
The accreditations are added to the footer at https://github.com/Bixal/bixal-site-drupal/pull/304/files#diff-403405aee515577c358da9d49904bc3564354594cae76b6d62540e8f711787d2R48 and https://github.com/Bixal/bixal-site-drupal/pull/304/files#diff-403405aee515577c358da9d49904bc3564354594cae76b6d62540e8f711787d2R46. However these are rendered, they need to depend on the cache tag that is used to get the data. Ie, the object that is updated when https://www.bixal.com/admin/content/accreditations is saved.

Because this does not happen, when the accreditations are saved, they Drupal cache is not cleared so the changes will not be shown.

To Reproduce

  1. Go to the homepage as an anonymous user
  2. Open an new browser or incognito and login as admin
  3. Go to /admin/content/accreditations
  4. Make a change to the accreditations
  5. Go back to the homepage as an anonymous user

Expected behavior
Changes made are shown after the update.

@mattsqd mattsqd added bug Something isn't working Drupal Requires integration from the Drupal side. labels Oct 21, 2024
@mattsqd
Copy link
Collaborator Author

mattsqd commented Oct 21, 2024

Please note that this is most likely a bug in config_pages as I used their API to grab the data, unless I got it wrong. Check the issue queue first. Check for a better API to retrieve the fields or submit a patch to make proper cache dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Drupal Requires integration from the Drupal side.
Projects
None yet
Development

No branches or pull requests

1 participant