Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bixal-site-drupal - feature request: Update to section header of Case Studies #349

Open
mattsqd opened this issue Nov 22, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@mattsqd
Copy link
Collaborator

mattsqd commented Nov 22, 2024

Is your feature request related to a problem? Please describe.

The header should be closer to the second page, instead of the first page of these designs:
image

Here's what we have now:
image

Describe the solution you'd like

Changes:

  1. Client below title
  2. No pipes around client
  3. The string Client | should be added in front of each client

Don't change:

  • The header colors are fine even though the design doesn't match the implementation. These match the initial designs though.
@mattsqd mattsqd added the enhancement New feature or request label Nov 22, 2024
@mejiaj
Copy link
Collaborator

mejiaj commented Nov 22, 2024

@mattsqd the submitted designs didn't match the Bixal styleguide, so not an issue that they don't match.

The problem with Client | Department of Labor and Education especially if it's in all caps is that screen readers will read it as:

Client vertical line Department of Labor and Education

Is it possible to add most of this in the template? I'm thinking of something like:

<p>
  Client <span aria-hidden="true">|</span> {{ CLIENT_NAME }}
</p>

Or if we want to have all caps:

<!-- Screen readers will read aria-label and ignore text inside. -->
<p aria-label="Client: Department of Labor and Education">
  CLIENT | {{ CLIENT_NAME }}
</p>

mattsqd added a commit that referenced this issue Nov 26, 2024
mattsqd added a commit that referenced this issue Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants