Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: function CreateAccessList() is not working #89

Closed
18aaddy opened this issue Oct 29, 2024 · 6 comments
Closed

bug: function CreateAccessList() is not working #89

18aaddy opened this issue Oct 29, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@18aaddy
Copy link

18aaddy commented Oct 29, 2024

In execution/http_rpc.go, the function CreateAccessList() is throwing an error. It is not able to unmarshal data from the rpc to types.AccessList struct.

@18aaddy
Copy link
Author

18aaddy commented Oct 29, 2024

@ABD-AZE can you try and fix this? You can use the tests from PR #88

@ABD-AZE
Copy link

ABD-AZE commented Oct 29, 2024

The type accesslist needs to be changed, @x-senpai-x has defined the new type in evm.go. Once he changes the type I'll look into this.

@gerceboss
Copy link
Contributor

@ABD-AZE please be quick as there are 2 PRs that require this code to be merged first

@ABD-AZE
Copy link

ABD-AZE commented Oct 30, 2024

I'll do it by EOTD

@18aaddy
Copy link
Author

18aaddy commented Oct 30, 2024

@gerceboss I think my PR #88 for http_rpc test might need to be merged first and this should be afterwards. I have modified the http_rpc file so that every other test passes and then the CreateAccessList function can be modified so that TestCreateAccessList passes

@star-gazer111 star-gazer111 added the bug Something isn't working label Nov 4, 2024
@18aaddy
Copy link
Author

18aaddy commented Nov 5, 2024

Resolved here #107

@18aaddy 18aaddy closed this as completed Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants