Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implemented consensus/types #25

Merged
merged 4 commits into from
Sep 15, 2024
Merged

implemented consensus/types #25

merged 4 commits into from
Sep 15, 2024

Conversation

ABD-AZE
Copy link

@ABD-AZE ABD-AZE commented Aug 31, 2024

Resolves #19

  1. Implemented all the types in the consensus/types directory.
  2. The struct fields are capitalized to be exported, If exporting them is not required we can change them later after testing (Currently all struct fields are exported)
  3. Size of some containers was to be kept less than some max value so currently I have allotted them fixed size i.e. the maximum size. In future if we come up with some memory efficient alternative it can be changed.
  4. Serialization and Deserialization methods are defined for the required structs. (Require Review on whether it is correct or not).

@ABD-AZE ABD-AZE marked this pull request as draft August 31, 2024 13:33
@ABD-AZE ABD-AZE marked this pull request as ready for review August 31, 2024 13:33
@star-gazer111
Copy link
Member

@ABD-AZE any updates on the requested changes?

@ABD-AZE
Copy link
Author

ABD-AZE commented Sep 15, 2024

@ABD-AZE any updates on the requested changes?

I'll commit the changes by EOTD

@ABD-AZE
Copy link
Author

ABD-AZE commented Sep 15, 2024

@ABD-AZE any updates on the requested changes?

I have just removed the serializaion and deserialization functions. Wherever the need for de/serializing would be required it can be done by importing from the packages mentioned in the review. In this package there was no such need for the functions to be imported.

@star-gazer111
Copy link
Member

@ABD-AZE any updates on the requested changes?

I have just removed the serializaion and deserialization functions. Wherever the need for de/serializing would be required it can be done by importing from the packages mentioned in the review. In this package there was no such need for the functions to be imported.

Are there any more changes you plan to do in this PR?

@ABD-AZE
Copy link
Author

ABD-AZE commented Sep 15, 2024

@ABD-AZE any updates on the requested changes?

I have just removed the serializaion and deserialization functions. Wherever the need for de/serializing would be required it can be done by importing from the packages mentioned in the review. In this package there was no such need for the functions to be imported.

Are there any more changes you plan to do in this PR?

Nothing as of now.

@star-gazer111 star-gazer111 merged commit fb59b2e into BlocSoc-iitr:dev Sep 15, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants