Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/test execution state #76

Closed
wants to merge 60 commits into from

Conversation

18aaddy
Copy link

@18aaddy 18aaddy commented Oct 23, 2024

Resolves #75
Written tests for execution/state.go

  • Written tests for all functions
  • Working locally (all tests passing)

I haven't written tests separately for PushBlock and PushFinalizedBlock as they are already covered in other tests

@18aaddy
Copy link
Author

18aaddy commented Oct 23, 2024

The lint test is failing because of a for loop
for state.finalizedBlock == nil {}
This is needed as it waits for the finalized block to be pushed before continuing. If it doesn't wait, it could lead to unexpected results.
This is only a warning at compilation time, not an error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants