-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test/test execution execution.go #96
Test/test execution execution.go #96
Conversation
Here, the test checks are failing because the The lint is failing because of a for loop in the test file but the loop is needed as it waits for the blocks to be pushed into state before running tests. Without the loop, the test fails. Also, locally it is only a warning, not an error |
@18aaddy , make changes according to the one that @x-senpai-x writes |
You mean the types.AccessList PR? #94 |
@gerceboss This PR contains all tests for http_rpc and execution.go and all tests are passing. This can be merged with no need to merge #88 or #90. Then @ABD-AZE can work on CreateAccessList function. The lint is failing because of a for loop, and I tried to replace that but the tests were failing. It is only a warning while running locally. |
I am closing this PR. PR #100 can be used instead |
This addresses #95
I have written tests for all functions in
execution/execution.go
exceptGetAccount()
andGetTransactionReceipt()
as they depend on state and need to have valid proofs in order to work.I have made some modifications to execution.go which solved some errors.
This PR depends on my earlier PR #90 as proof.go had been updated in that. It should be merged after PR #90