Add the ability to make warning signs glow with glow ink sacks, closes #6003

Author: BluSunrize

changelog.md

@@ -7,6 +7,7 @@
     - This comes with a new render function for datapacks to handle double-high crops, which is also used by hemp
 - Add treated wood, steel and aluminium signs (BluSunrize)
     - They work like vanilla signs, not much else to say
+- Add the ability to make warning signs glow with glow ink sacks (BluSunrize)
 - Remove CustomParticleManager (IMS)
 - Change High Explosive cartridges to return shells on use (voidsong-dragonfly)
 - Change hemp plants to use the same "half" property as vanilla double flowers (BluSunrize)

src/main/java/blusunrize/immersiveengineering/common/blocks/metal/WarningSignBlock.java

@@ -14,22 +14,46 @@
 import com.google.common.collect.ImmutableList;
 import net.minecraft.core.BlockPos;
 import net.minecraft.core.Direction;
+import net.minecraft.stats.Stats;
 import net.minecraft.util.StringRepresentable;
 import net.minecraft.util.Unit;
+import net.minecraft.world.InteractionHand;
+import net.minecraft.world.ItemInteractionResult;
+import net.minecraft.world.entity.player.Player;
+import net.minecraft.world.item.DyeColor;
+import net.minecraft.world.item.ItemStack;
+import net.minecraft.world.item.Items;
 import net.minecraft.world.item.context.BlockPlaceContext;
 import net.minecraft.world.level.BlockGetter;
+import net.minecraft.world.level.Level;
 import net.minecraft.world.level.block.Block;
+import net.minecraft.world.level.block.SoundType;
 import net.minecraft.world.level.block.state.BlockState;
 import net.minecraft.world.level.block.state.StateDefinition.Builder;
 import net.minecraft.world.level.block.state.properties.BlockStateProperties;
+import net.minecraft.world.level.block.state.properties.BooleanProperty;
+import net.minecraft.world.level.gameevent.GameEvent;
+import net.minecraft.world.level.gameevent.GameEvent.Context;
+import net.minecraft.world.level.material.MapColor;
 import net.minecraft.world.phys.AABB;
+import net.minecraft.world.phys.BlockHitResult;
 import net.minecraft.world.phys.shapes.CollisionContext;
 import net.minecraft.world.phys.shapes.VoxelShape;
 
 import java.util.Locale;
+import java.util.function.Supplier;
 
 public class WarningSignBlock extends IEBaseBlock
 {
+	private static final BooleanProperty GLOWING = BooleanProperty.create("glowing");
+	public static final Supplier<Properties> PROPERTIES = () -> Block.Properties.of()
+			.mapColor(MapColor.METAL)
+			.sound(SoundType.METAL)
+			.strength(3, 15)
+			.requiresCorrectToolForDrops()
+			.isViewBlocking((state, blockReader, pos) -> false)
+			.lightLevel(b -> b.getValue(GLOWING)?9: 0);
+
 	private final WarningSignIcon icon;
 
 	public WarningSignBlock(WarningSignIcon icon, Properties properties)
@@ -42,7 +66,13 @@ public WarningSignBlock(WarningSignIcon icon, Properties properties)
 	protected void createBlockStateDefinition(Builder<Block, BlockState> builder)
 	{
 		super.createBlockStateDefinition(builder);
-		builder.add(IEProperties.FACING_HORIZONTAL, BlockStateProperties.WATERLOGGED);
+		builder.add(IEProperties.FACING_HORIZONTAL, BlockStateProperties.WATERLOGGED, GLOWING);
+	}
+
+	@Override
+	protected BlockState getInitDefaultState()
+	{
+		return super.getInitDefaultState().setValue(GLOWING, false);
 	}
 
 	@Override
@@ -61,6 +91,23 @@ public VoxelShape getShape(BlockState state, BlockGetter blockGetter, BlockPos b
 		return SHAPES.get(Unit.INSTANCE, state.getValue(IEProperties.FACING_HORIZONTAL));
 	}
 
+	@Override
+	public ItemInteractionResult useItemOn(ItemStack stack, BlockState state, Level level, BlockPos pos, Player player, InteractionHand hand, BlockHitResult hitResult)
+	{
+		if(stack.is(Items.GLOW_INK_SAC))
+		{
+			if(!level.isClientSide())
+			{
+				player.awardStat(Stats.ITEM_USED.get(stack.getItem()));
+				state = state.setValue(GLOWING, true);
+				level.setBlock(pos, state, 3);
+				level.gameEvent(GameEvent.BLOCK_CHANGE, pos, Context.of(player, state));
+				stack.consume(1, player);
+			}
+			return ItemInteractionResult.SUCCESS;
+		}
+		return super.useItemOn(stack, state, level, pos, player, hand, hitResult);
+	}
 
 	public enum WarningSignIcon implements StringRepresentable
 	{

src/main/java/blusunrize/immersiveengineering/common/register/IEBlocks.java

@@ -580,7 +580,7 @@ private static void init()
 			}
 			for(WarningSignIcon icon : WarningSignIcon.values())
 				WARNING_SIGNS.put(icon, new BlockEntry<>(
-						"warning_sign_"+icon.getSerializedName(), METAL_PROPERTIES_NO_OVERLAY, blockProps -> new WarningSignBlock(icon, blockProps)
+						"warning_sign_"+icon.getSerializedName(), WarningSignBlock.PROPERTIES, blockProps -> new WarningSignBlock(icon, blockProps)
 				));
 		}
 	}

src/main/resources/assets/immersiveengineering/manual/en_us/warning_signs.txt

@@ -3,4 +3,5 @@ Warning: Excessive signage ahead
 Factories and warehouses are often grimy, unsafe, and riddled with chemicals and steam clouding the air.<br>
 If reducing these hazards is inefficient, newly standardized Warning Signs can be used to warn of dangers instead.
 <&sign_recipes>Warning signs can be crafted from any metal backing plate and yellow dye, to make sure the signs are visible on gloomy factory floors.<br>
-Signs can be placed on any vertical block face, but cannot be placed on the floor or on the ceiling.
+Signs can be placed on any vertical block face, but cannot be placed on the floor or on the ceiling.<br>
+Using a §2glow ink sack§r on a placed sign will make it emit a low amount of light.