Skip to content

Commit

Permalink
Tidy
Browse files Browse the repository at this point in the history
  • Loading branch information
dantb committed Mar 28, 2024
1 parent af4829f commit 1fa153a
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ trait StorageAccess {
}

object StorageAccess {
def mk(
final private[storage] def mk(
remoteStorageClient: RemoteDiskStorageClient,
s3Client: S3StorageClient
): StorageAccess = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,8 @@ object S3StorageClient {
S3AsyncClient
.builder()
.credentialsProvider(creds)
// TODO does this need to be changed on the fly?
.endpointOverride(URI.create(cfg.defaultEndpoint.toString()))
.forcePathStyle(true)
// TODO may want to configure this?
.region(Region.US_EAST_1)
)
.map(new S3StorageClientImpl(_))
Expand Down

0 comments on commit 1fa153a

Please sign in to comment.