From 0ecdb4c2d4e8715d6456741e21a981d8009172dd Mon Sep 17 00:00:00 2001 From: Nathan Young Date: Wed, 1 May 2024 13:12:15 -0400 Subject: [PATCH] Apply suggestions from code review these were reverted changes that got missed after the renaming rebase Co-authored-by: Matthew Marine --- .../Filters/Algorithms/ITKImportFijiMontage.cpp | 2 +- src/simplnx/DataStructure/DataObject.hpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Plugins/ITKImageProcessing/src/ITKImageProcessing/Filters/Algorithms/ITKImportFijiMontage.cpp b/src/Plugins/ITKImageProcessing/src/ITKImageProcessing/Filters/Algorithms/ITKImportFijiMontage.cpp index 2b87ce2ec2..2b5d62daf7 100644 --- a/src/Plugins/ITKImageProcessing/src/ITKImageProcessing/Filters/Algorithms/ITKImportFijiMontage.cpp +++ b/src/Plugins/ITKImageProcessing/src/ITKImageProcessing/Filters/Algorithms/ITKImportFijiMontage.cpp @@ -269,7 +269,7 @@ class IOHandler // rename grayscale array to reflect original { auto& gray = m_DataStructure.getDataRefAs(imageDataPath.replaceName("gray" + imageDataPath.getTargetName())); - if(gray.canRename(imageDataPath.getTargetName()) != 1) + if(gray.canRename(imageDataPath.getTargetName()) == false) { return MakeErrorResult(-18543, fmt::format("Unable to rename the grayscale array to {}", imageDataPath.getTargetName())); } diff --git a/src/simplnx/DataStructure/DataObject.hpp b/src/simplnx/DataStructure/DataObject.hpp index 1198bde9ce..adc004913c 100644 --- a/src/simplnx/DataStructure/DataObject.hpp +++ b/src/simplnx/DataStructure/DataObject.hpp @@ -205,7 +205,7 @@ class SIMPLNX_EXPORT DataObject * @brief Checks and returns if the DataObject can be renamed to the provided * value. * @param name - * @return int: 0 = false, 1 = true, 2 = duplicate object found + * @return bool */ bool canRename(const std::string& name) const;