Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Isolate Largest Feature Filter may not actually be doing anything? #1144

Open
imikejackson opened this issue Nov 23, 2024 · 1 comment · May be fixed by #1169
Open

BUG: Isolate Largest Feature Filter may not actually be doing anything? #1144

imikejackson opened this issue Nov 23, 2024 · 1 comment · May be fixed by #1169
Assignees
Labels
bug Something isn't working

Comments

@imikejackson
Copy link
Contributor

imikejackson commented Nov 23, 2024

Tried to use this filter on some pretty obvious data and it had no effect or at least not the effect that I was expecting.

I would expect that in the following images, the "holes" in the interior of the white feature would have been filled in with a different value for the mask than the exterior of the white feature.

Screenshot 2024-12-03 at 17 58 36

Example Data File

simplnx_1144_input_file.zip

@imikejackson imikejackson added the bug Something isn't working label Dec 3, 2024
@imikejackson imikejackson changed the title BUG: Isolate largest feature may not actually be doing anything? BUG: Identify Sample Filter may not actually be doing anything? Dec 3, 2024
@imikejackson imikejackson changed the title BUG: Identify Sample Filter may not actually be doing anything? BUG: Isolate Largest Feature Filter may not actually be doing anything? Dec 3, 2024
@imikejackson
Copy link
Contributor Author

@joeykleingers After the discussion, these 2 things need to happen.

1: Add/Update the documentation to make it clear some of the assumptions that are made about the data
2: Investigate the included data set as to why the holes are not filled in by cropping out a section in the "middle" of the data set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants