From 089d7b3a1145f6a91b190950fb2dd717fc86f70e Mon Sep 17 00:00:00 2001 From: Michael Jackson Date: Thu, 18 Jul 2024 15:16:42 -0400 Subject: [PATCH] BUG: ArraySelection Parameters linked to ChoiceParameter cannot be empty - If an Array Selection Parameter is linked to a choice parameter the validate() function is called regardless whether the proper choice that activates that parameter is selected. This commit fixes the bug and restores the intended behavior. Signed-off-by: Michael Jackson --- src/simplnx/Filter/Parameters.cpp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/simplnx/Filter/Parameters.cpp b/src/simplnx/Filter/Parameters.cpp index ce5973f238..95a06245ad 100644 --- a/src/simplnx/Filter/Parameters.cpp +++ b/src/simplnx/Filter/Parameters.cpp @@ -127,7 +127,11 @@ bool Parameters::isParameterActive(std::string_view key, const Arguments& args) const IParameter* groupParameter = at(groupKey).get(); - isActive |= func(*groupParameter, value, associatedValue); + isActive = func(*groupParameter, value, associatedValue); + if(isActive) + { + break; + } } return isActive;