Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new Computation testing helper function from IEGenLib in spf-ie #35

Open
riftEmber opened this issue Sep 23, 2021 · 3 comments
Open
Assignees

Comments

@riftEmber
Copy link
Member

The Computation::expectEqualTo method that we use in spf-ie tests no longer exists. Need to copy the helper functions expectStmtsEqual and expectComputationsEqual from IEGenLib over to the SPFComputationTest class in spf-ie, then use them in our tests.

@riftEmber
Copy link
Member Author

Forgot to mention, when I say "no longer exists" I mean it doesn't exist in newer commits of IEGenLib -- it exists on the commit we're linked to. As part of this issue you should bump the IEGenLib commit pointer in our CMakeLists to the newest commit on IEGenLib.

@riftEmber
Copy link
Member Author

Did this because I needed it for further development

@kalyanbhetwal
Copy link
Collaborator

I implemented the code but realized that it has never been pushed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants