Merge pull request #29 from BonnierNews/feat/async-import-gcp-metadata

do not import gcp-metadata rabbithole, if not needed
BonnierNews · Dec 10, 2024 · ada406d · ada406d
2 parents 73bf6b9 + 301deef
commit ada406d
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/lib/gcp.ts b/lib/gcp.ts
@@ -1,5 +1,3 @@
-import gcpMetaData from "gcp-metadata";
-
 /**
  * Fetches the Google Cloud Platform (GCP) project ID from the GCP metadata server.
  *
@@ -9,7 +7,7 @@ export async function getGcpProjectId(): Promise<string | undefined> {
   if (process.env.GCP_PROJECT) {
     return process.env.GCP_PROJECT;
   }
-
+  const gcpMetaData = await import("gcp-metadata");
   const isAvailable = await gcpMetaData.isAvailable();
   if (!isAvailable) return;
 

diff --git a/lib/logging.ts b/lib/logging.ts
@@ -55,6 +55,7 @@ export function logger(options: LoggerOptions = {}, stream?: DestinationStream |
     messageKey = "message",
     timestamp = () => `,"time": "${new Date().toISOString()}"`,
     formatLog,
+    /* c8 ignore start */
     transport = shouldPrettyPrint
       ? {
         target: "pino-pretty",
@@ -65,6 +66,7 @@ export function logger(options: LoggerOptions = {}, stream?: DestinationStream |
         },
       }
       : undefined,
+    /* c8 ignore stop */
     mixin,
     ...rest
   } = options;

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@bonniernews/logger",
-  "version": "0.0.9",
+  "version": "0.0.10",
   "description": "Some simple functions to use Trace Context for correlating logs",
   "type": "module",
   "main": "./dist/index.cjs",