From ff29256db15fa134f57dac7799d3cad56b90ddf5 Mon Sep 17 00:00:00 2001 From: Jon Eldeklint Date: Mon, 2 Dec 2024 12:14:04 +0100 Subject: [PATCH 1/3] do not import gcp-metadata rabbithole, if not needed --- lib/gcp.ts | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lib/gcp.ts b/lib/gcp.ts index 77c78fd..7bd56e6 100644 --- a/lib/gcp.ts +++ b/lib/gcp.ts @@ -1,5 +1,3 @@ -import gcpMetaData from "gcp-metadata"; - /** * Fetches the Google Cloud Platform (GCP) project ID from the GCP metadata server. * @@ -9,7 +7,7 @@ export async function getGcpProjectId(): Promise { if (process.env.GCP_PROJECT) { return process.env.GCP_PROJECT; } - + const gcpMetaData = await import("gcp-metadata"); const isAvailable = await gcpMetaData.isAvailable(); if (!isAvailable) return; From a2626c284ab32d70abc02d5eb067715f5e31ed91 Mon Sep 17 00:00:00 2001 From: Mattias Olla Date: Tue, 10 Dec 2024 09:41:32 +0100 Subject: [PATCH 2/3] Add back c8 ignore comments to fix test coverage --- lib/logging.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/logging.ts b/lib/logging.ts index 1a428f4..bd19f80 100644 --- a/lib/logging.ts +++ b/lib/logging.ts @@ -55,6 +55,7 @@ export function logger(options: LoggerOptions = {}, stream?: DestinationStream | messageKey = "message", timestamp = () => `,"time": "${new Date().toISOString()}"`, formatLog, + /* c8 ignore start */ transport = shouldPrettyPrint ? { target: "pino-pretty", @@ -65,6 +66,7 @@ export function logger(options: LoggerOptions = {}, stream?: DestinationStream | }, } : undefined, + /* c8 ignore stop */ mixin, ...rest } = options; From 301deef904e812bd1140917ab34d9b4f6d9455c8 Mon Sep 17 00:00:00 2001 From: Mattias Olla Date: Tue, 10 Dec 2024 09:42:16 +0100 Subject: [PATCH 3/3] Bump version --- package-lock.json | 4 ++-- package.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/package-lock.json b/package-lock.json index c6ce624..d40281d 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "@bonniernews/logger", - "version": "0.0.9", + "version": "0.0.10", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "@bonniernews/logger", - "version": "0.0.9", + "version": "0.0.10", "license": "MIT", "dependencies": { "gcp-metadata": "^6.1.0", diff --git a/package.json b/package.json index 288d48e..4ad833f 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@bonniernews/logger", - "version": "0.0.9", + "version": "0.0.10", "description": "Some simple functions to use Trace Context for correlating logs", "type": "module", "main": "./dist/index.cjs",