Future proofing isSampled #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assensamuelsson
requested review from
wisko,
kristofferjansson and
MattiasOlla
MattiasOlla
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Future prooing the calculation of
isSampled.The Trace Context specification only now supports 1 trace flag meaning the current implementation works.
However if the specification decides to add more flags it could lead to
isSampledbeing incorrectly set.E.g.
traceFlags: "02"would setisSampledwhen the least significant bitFLAG_SAMPLEDactually is not set.Make sure we only check if the
FLAG_SAMPLEDbit is set when calculatingisSampled.