Skip to content

Commit

Permalink
Merge pull request #38 from BonnierNews/bump/node-18
Browse files Browse the repository at this point in the history
Bump to node 18
  • Loading branch information
varney authored Mar 2, 2023
2 parents 9f7ac8e + f72dd06 commit 728c497
Show file tree
Hide file tree
Showing 7 changed files with 2,354 additions and 2,015 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,22 +11,22 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [10.x, 12.x, 14.x]
node-version: [12.x, 14.x, 16.x, 18.x]

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}

- name: Start docker containers
run: docker-compose up --build -d postgres

- name: Install dependencies
run: npm install
run: npm ci
env:
NODE_ENV: "test"

- name: Run feature tests
run: npm test
run: npm test
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
14
18
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
FROM node:8
FROM node:18
ADD package.json /app/package.json
RUN cd /app && npm i
RUN cd /app && npm ci
ADD . /app

2 changes: 1 addition & 1 deletion docker-compose.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
version: '3'
services:
postgres:
image: postgres:9
image: postgres:14
restart: always
ports:
- "5435:5432"
Expand Down
Loading

0 comments on commit 728c497

Please sign in to comment.