Vertical orientated slideshow #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based several calculations on the 'orientation' setting.
Based some css on vertical orientation
Added the option 'Orientation', to allow a vertical oriented slideshow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Mr. Boonstra,
Over two years ago I suggested an option for a vertical orientated slideshow through the Wordpress support page, and last weekend I made it work (with my first lines of plugin code ever ^^). Also I did create a GitHub account specially for this and am not sure everything is going fine this way.
The code adjustments are backwards compatible for existing slideshows and only adds some simple if/else statements in 3 files (so far). It's working nicely on my website, but to make it really nice the 'previous/next' buttons need to be moved to the top and bottom of the slideshow.
Can you please take a look into the adjustments and (hopefully) implement them in the master branch?
Or do you have a better idea to implement this feature?
Best regards,
Leo