feat: print additional debug info if debug set to true in get middleware #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeaOfTea
approved these changes
Aug 2, 2024
src/index.js
Outdated
| @@ -35,16 +35,18 @@ const addCheck = (check) => healthChecks.push(check); | |||
| const addReadinessCheck = (check) => readinessChecks.push(check); | |||
| const addMetrics = (m) => { metrics = m; }; | |||
|
|
|||
| const getMiddleware = () => (req, res, next) => { | |||
| const getMiddleware = (debug = false) => (req, res, next) => { | |||
Jafferwaffer
force-pushed
the
AS-454-v3-release
branch
from
dcc04dd to
e77d13a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://brandwatch.atlassian.net/browse/AS-454
Final change of the v3 changes.
Have tested on the following clusters
Added a way to print out ips that dont match the range JIC someone needs to debug.