Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save MySQL/Database credentials & settings as database.yml seperate so that its not pushed to github. #30

Open
TomLewis opened this issue Aug 29, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@TomLewis
Copy link

I manage my configs for plugins using Github and I also use test server/prod server which use different credentials and database setups.

please can you seperate the MySQL storage settings into its own file, so that it can be git ignored so its not pushed to the github exposing sensative details.

This is also a pain when you have 2 systems, I cant have one config.yml with a single database setting as my prod is different from my local dev, so there;s no way to easily have the files push to git, because I need a separate config.yml for local testing... very easily solved by separating database connection details, its why a lot of plugins separate the database info into its own file.

@TomLewis TomLewis changed the title Save MySQL data as mysql.yml seperate so that its not pushed to github. Save MySQL data as database.yml seperate so that its not pushed to github. Aug 29, 2024
@TomLewis TomLewis changed the title Save MySQL data as database.yml seperate so that its not pushed to github. Save MySQL/Database credentials & settings as database.yml seperate so that its not pushed to github. Aug 29, 2024
@Starmism
Copy link

Starmism commented Sep 2, 2024

+1, same for my server setup which uses a shared config that has different database connection details on each server.

@Mitality Mitality added the enhancement New feature or request label Sep 5, 2024
@Jsinco
Copy link
Member

Jsinco commented Nov 21, 2024

This probably won't be coming since our new configs #56 have allowed us to diverge the recipes, custom items, and cauldron ingredients into their own respective files (recipes.yml, cauldron.yml, custom-items.yml). You can keep your sensitive data inside your config and push your recipes.yml to github.

If this feature is still requested after implementing okaeri, then I'll revisit it.

@TomLewis
Copy link
Author

That seems a lot neater, should have had a /recipes folder, that can either contain a single file, or multiple files, so then you can seperate events/seasons into their own files.

I will have to trial the update, I had to backdate due to a plethora of issues with all sorts of lore and whatnot, so im using an older version atm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants