Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Preprocessor option for MSVC in CMakeLists.txt #746

Open
Lubart opened this issue May 1, 2023 · 1 comment
Open

Add Preprocessor option for MSVC in CMakeLists.txt #746

Lubart opened this issue May 1, 2023 · 1 comment

Comments

@Lubart
Copy link

Lubart commented May 1, 2023

Can preprocessor option (Enable preprocessor conformance mode) be added to CMakeLists.txt.
That option is:

if (MSVC)
add_compile_options(/Zc:preprocessor)
endif()

In order to have it already in VC project options.
https://learn.microsoft.com/en-us/cpp/build/reference/zc-preprocessor?view=msvc-170

@matty0ung
Copy link
Contributor

Sorry you didn't get a reply on this before. The main reason we don't support MSVC out of the box is that I haven't worked out how to script all the installation etc. At some point, I would love to get the build working on MSVC so that we're compiling on all three mainstream C++ compilers, but, realistically, it's going to be a while before that gets to the top of my to-do list. In the meantime, I'm happy to look at PRs if you or anyone else want to take a shot at doing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants