Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

map work #151

Open
esaule opened this issue Dec 20, 2024 · 2 comments
Open

map work #151

esaule opened this issue Dec 20, 2024 · 2 comments
Assignees

Comments

@esaule
Copy link
Member

esaule commented Dec 20, 2024

There is a lot to do in the support of maps in the C++ client
(we'll eventually port those to the other languages)

  1. The state and county object have getter functions but not setter functions
  2. The getter functions should be const
  3. The colors in the objects should be Bridges Color object and not string
  4. The datasource object should support importing all the states at once
  5. The datasource object should support importing the states but not the counties
@krs-world
Copy link
Contributor

Done with 1, 2 and 3 above, but JSON creation code is not updated for the r,g,b colors yet.

@esaule
Copy link
Member Author

esaule commented Dec 26, 2024

I think at this point the only thing we miss is documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants