Friendlier error for spaces in Bridges argument

[squeetus]

For the main Bridges call (assignmentNumber, "username", "apikey"), if a user passes a username or apikey argument containing a space character then we get an ugly error message about invalid JSON. We should trap this error somehow and generate a more helpful message.

[esaule]

Is that linked to a bad encoding in the url? or is generated JSON screwed up?

[krs-world]

If you are talking about for our testing  repo (Bridges arguments), I dont think we care. Or you talking of something else?     -- krs

On 1/3/19 10:35 PM, Erik Saule wrote: Is that linked to a bad encoding in the url? or is generated JSON screwed up? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#123 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFZSOGwYkq2SLzwDP3vgO-Ga_aILuwYwks5u_svrgaJpZM4XYkSt>.

-- Kalpathi Subramanian Ph: 704 687 8579 Associate Professor Email: [email protected] Dept of Computer Science Web:http://webpages.uncc.edu/krs The University of North Carolina Charlotte, NC 28202-0001

[squeetus]

Currently in the Java client, usernames with spaces are modified to encode spaces as '+' signs, so this issue only occurs if someone passes an apikey string including a space to Bridges. This causes the query parameter of the post url to be malformed, and Java throws an 'Illegal character in query' exception.

Perhaps this is ok - user's apikey strings are pretty self-explanatory. But we also could check the string when we create the Bridges object to make sure it is a valid apikey format.

This is not critical.