Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getDataSetJSON is incorrectly named #186

Open
esaule opened this issue Aug 8, 2024 · 0 comments
Open

getDataSetJSON is incorrectly named #186

esaule opened this issue Aug 8, 2024 · 0 comments

Comments

@esaule
Copy link
Member

esaule commented Aug 8, 2024

The getDataSetJSON function does not care what it returns. So it doesn't care wheter it is JSON or not. So probably the function should not have JSON in its name.
probably should be called getDataSetCached since this fundamentally what it does.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@esaule