New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reference to deprecated dev library - blocking upgrade to eslint 9 #30

Open

josephsaffron opened this issue Apr 22, 2024 · 1 comment

josephsaffron commented Apr 22, 2024

When stylelint was upgrade from 14-15, post-css-in-js was deprecated - instead, there are custom parsers. https://github.com/stylelint/stylelint/blob/main/docs/migration-guide/to-15.md#breaking-changes
One of those is https://www.npmjs.com/package/postcss-lit - Is there a reason we shouldn't switch to using this?

Contributor

dbatiste commented Apr 22, 2024

It's probably something worth looking into. Not all of our CSS is in a Lit component though. For example:

in a css template within a module: typography styles.css; (currently linted)
in a style block within a module colors.js (not sure if this is currently linted)

So we'll want to play around with it to ensure we'd be getting the coverage we want/need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment