Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is rename-core SvelteKit app? #5

Open
davemaul opened this issue Feb 22, 2022 · 2 comments
Open

Why is rename-core SvelteKit app? #5

davemaul opened this issue Feb 22, 2022 · 2 comments
Labels
question Further information is requested

Comments

@davemaul
Copy link

When running npm run build in a clean copy of your scaffolding, the process fails due to a missing routes directory in rename-core. It'd be more than easy to fix this issue by adding a packages/rename-core/src/routes/.gitkeep file. However, I wonder why the core package even has to be a SvelteKit app rather than a Svelte component library.

Is it just work in progress or is there a reason for this? 🙃

By the way, thanks for this awesome repo!

@Brisklemonade
Copy link
Owner

Thank you for pointing that out. When I made this repo I had the intention of updating it because a lot of it was placeholder. However, a lot more people are utilizing it than I thought. So soon I will be going through it and updating it accordingly. Thank you for the feedback!

@Brisklemonade
Copy link
Owner

Brisklemonade commented Feb 23, 2022

@logineimer I also want to point out, it is a component library package. The lib folder acts as the library. When you run
npm run package it will make an optimized build of your package to publish to npm.

@Brisklemonade Brisklemonade added the question Further information is requested label Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants