-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Recoordination Process with Ghost Point #12
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The majority of these changes had already been reviewed by @volcan01010, but following the discussion with Matt some additional changes were made which can be seen in this commit: 66b4373 @ximenesuk has reviewed these additional changes to ensure the modified transformation logic makes sense. |
ximenesuk
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This merge request implements the following:
Description
Recoordination
The recoordination functionality has been implemented according to Matt's specifications and feedback, as seen in #4. For this functionality, the environment has been modified to include
numpy
to perform the affine transformation.Ghost Point
A ghost point feature has been added following feedback seen in #6. This feature can be enabled/disabled by the user, as per feedback from Matt.
Code Refinement
To accommodate both of the new features, much of the internal logic has been overwritten to make it more versatile and less complex. For example, many of the parsing methods have been moved into a separate file, away form the front-end code. These logic changes have also solved the bug detailed in #9.
Moreover, due to the addition of
numpy
, the compiledexe
file was considerably larger, initially being 270MB. Previously, theexe
file was only 37MB, and so some additional changes have been made to the environment to reduce this size down. As it stands, the newexe
file size is 75MB with all the new functionality andnumpy
included. The solution used comes from 2 discussions online:Many tests have been added to ensure all of the new functionality works as expected.
Documentation
Closes #4, #6, #9