Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve PreProcessing workflow to support BVR cfg generation #131

Open
jcfr opened this issue Oct 28, 2024 · 8 comments · May be fixed by #141
Open

Improve PreProcessing workflow to support BVR cfg generation #131

jcfr opened this issue Oct 28, 2024 · 8 comments · May be fixed by #141
Assignees

Comments

@jcfr
Copy link
Contributor

jcfr commented Oct 28, 2024

See https://autoscoper.readthedocs.io/en/latest/file-specifications/config.html

@amymmorton amymmorton changed the title Improve config file format to support updated BVR generation process Improve PreProcessing workflow to support BVR cfg generation Oct 28, 2024
@jdholt04
Copy link

For us, the most useful UI to generate a config file would have inputs controls to identify Calibration, Radiograph, and Volume subdirectories, Optimization Offsets (already present), Volume Flip (already present), Render Resolution (2 number input boxes), and Voxel Size (3 number input boxes). Calibration files, folders containing radiographs, and volume files would be parsed from the subdirectories (this assumes that calibration files and radiograph image folders have a camera identifier in their filename). The information from the input controls would be compiled into a .cfg file (Version 1.1).

For reference, here is the current Generate Config tab:

Picture1

@amymmorton
Copy link
Contributor

The advanced Options tab may be modified to meet some of these needs along with a more comprehensive Generate Config drop down

image

For reference, the folder explorer to the right shows the subdirectories typically found within the RadiographImages folder and the maycam files found in Calibration folder. (John - could you please add a screen shot from your projects too?)

Trial Name in General Input tab currently is a manual fill in... options for batch generation.. can't make too many file structure or naming restricitons

@jdholt04
Copy link

Here is a screenshot of the file structure for our project:

Capture

On the left: Trial directory, what we would set as our Output Directory, and where we would want to save a .cfg

On the right: Contents of RadiographImages, Calibration, and Volumes subdirectories

@amymmorton
Copy link
Contributor

@sbelsk do you have enough info to make a start on this - or do we need to do a quick show and tell? @jdholt04

@sbelsk
Copy link
Contributor

sbelsk commented Nov 4, 2024

That makes sense. A few more questions, to clarify:

volume files would be parsed from the subdirectories

Do we want to automatically load all volume files found in the specified volume subdirectory? Should we assume that the volume flip and voxel size properties are set once and they apply to all volumes files found?

Calibration files, folders containing radiographs [...] would be parsed from the subdirectories (this assumes that calibration files and radiograph image folders have a camera identifier in their filename)

Matching up the radiographs to their camera calibration files might be difficult in general if we don't require a certain name format/convention or if we don't tell SAM what exact name to look for. What are your thoughts on this?

@amymmorton
Copy link
Contributor

q1. Do we want to automatically load all volume files found in the specified volume subdirectory?
a1. No- I think we want to create a 'session' so to speak for the user. Using the preprocessing module- the affiliated segmentation node volumes linked in the partial volume gen should be used for the 'session'.

q2.Should we assume that the volume flip and voxel size properties are set once and they apply to all volumes files found?
a2. voxel size is set from the volume node referenced in the partial volume generation- so those value should be inherited and used for that 'session'. Keep volume flip manually adjustable (but yes all volumes are considered children of the same parent and should have the same vol flip vlaues)

@amymmorton
Copy link
Contributor

suggest #133 as step forward for this and #125

@sbelsk sbelsk linked a pull request Nov 10, 2024 that will close this issue
2 tasks
@amymmorton
Copy link
Contributor

@sbelsk suggest relocating trial name in the General Input ui drop down into the Generate Config group

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants