Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] FAQ 검색기능 추가 #222

Merged
merged 11 commits into from
Nov 18, 2024
Merged

[feat] FAQ 검색기능 추가 #222

merged 11 commits into from
Nov 18, 2024

Conversation

wnd01jun
Copy link
Contributor

@wnd01jun wnd01jun commented Nov 13, 2024

개요

#213
FAQ 검색기능이 필요하여 추가하였습니다.

PR

어떤 변경 사항이 있나요?

  • 새로운 기능 추가
  • 버그 수정
  • 문서 수정
  • 코드 포맷 변경, 세미콜론 누락, 코드 수정이 없는경우
  • 코드 리팩토링
  • 테스트 추가, 테스트 리팩토링
  • 빌드 수정, 패키지 매니저 수정
  • 파일, 폴더명 수정
  • 파일, 폴더 삭제

Checklist

  • 커밋 메시지 컨벤션에 맞게 작성했습니다.
  • 변경 사항에 대한 테스트를 했습니다.
  • 필요 없는 import문이나 setter 등을 삭제했습니다.
  • 기존의 코드에 영향이 없는 것을 확인했습니다.

@wnd01jun wnd01jun added the ⚙️ feature 새로운 기능 추가 label Nov 13, 2024
@wnd01jun wnd01jun self-assigned this Nov 13, 2024
@wnd01jun wnd01jun linked an issue Nov 13, 2024 that may be closed by this pull request
2 tasks
@wnd01jun wnd01jun changed the base branch from main to dev November 13, 2024 07:24
Comment on lines +67 to +71
@Override
@DeleteMapping("/{faqId}/keyword")
public ApiResponse<?> deleteKeyword(@PathVariable @ExistFaq Long faqId, @RequestParam Long searchKeywordId) {
return ApiResponse.onSuccess(faqService.removeKeyword(faqId, searchKeywordId));
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

해당 API는 키워드를 통해 FAQ를 지우는 메소드인걸까요??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FAQ와 연결된 searchKeyword mapping을 지우는 메소드 입니다!

Copy link
Contributor

@SoulTree-Lovers SoulTree-Lovers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

검색 기능 좋네요! 고생하셨습니다 :)

Copy link
Member

@m3k0813 m3k0813 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고 많으셨습니다!!

@wnd01jun wnd01jun merged commit c86667b into dev Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ feature 새로운 기능 추가
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] FAQ 검색기능 추가
3 participants