Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Inconsistency on Market Order #177

Open
CryptoChaser13 opened this issue Mar 19, 2020 · 7 comments
Open

Some Inconsistency on Market Order #177

CryptoChaser13 opened this issue Mar 19, 2020 · 7 comments
Assignees
Labels
bug Something isn't working low Low severity rewarded Sent the reward

Comments

@CryptoChaser13
Copy link

Hello. Ive seen some inconsistency on the dex' market order. You can see on the video, i have executed a market buy order under tomo/usdt pair , the order was rejected but the balance was deducted, making it transferred to my tomo balance. Now i try to execute a market sell to fill up again the usdt balance, so it was successfully executed. Now i try again to execute a market buy order, was again rejected but balance was deducted and transferred to my tomo balance. The video also indicates the notification of the rejection of the order.

https://youtu.be/-wLB-gZ7a8s

@CryptoChaser13 CryptoChaser13 added the bug Something isn't working label Mar 19, 2020
@thanhson1085
Copy link
Contributor

It is NOT an issue.
Your market order will be rejected at this case:
You place a SELL market order, it matched with 2 BUY orders. The first one is 9.5 TOMO, the second one is 0.5 TOMO.
Then your market order will be filled 9.5 TOMO, and have rejected status.

@thanhson1085
Copy link
Contributor

I discussed with team about this scenario.

We will improve this flow. We will not return "rejected" order this case, it seems make user confusing.
Thank you for the report.

@CryptoChaser13
Copy link
Author

That's what im claiming, why it posts Rejection yet the balance was deducted sir.

@thanhson1085
Copy link
Contributor

Confirmed for reward @chinhnt23 @victorngn

@thanhson1085 thanhson1085 added the low Low severity label Mar 20, 2020
@CryptoChaser13
Copy link
Author

Thanks sir @thanhson1085 by the way here is my tomo address:

0xafb82d9c2609ead9534774b16f9d1377d2decea3

@victorngn
Copy link

Noted that @MirasolFerrer, your reward will be sent on the first working day of April. Thanks

@victorngn
Copy link

Reward sent @MirasolFerrer

@victorngn victorngn added the rewarded Sent the reward label Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working low Low severity rewarded Sent the reward
Projects
None yet
Development

No branches or pull requests

4 participants