-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not able to pull 2018 pre-season stats #366
Comments
NFL.com is telling us that it is still 2017. See #363 for workaround. |
Yeah - I'm having the same issues myself! |
Please try the steps noted in #363 (comment) and let me know if you are still having problems. |
I have been using the live function to output games of the week to a LED sign I made. It seems this function isn't corrected by the solution you mentioned. I appreciate the help though |
I'm still not following what's not working... S:\>python
Python 2.7.14 (v2.7.14:84471935ed, Sep 16 2017, 20:19:30) [MSC v.1500 32 bit (Intel)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import nflgame
>>> games = nflgame.games(2018, kind='PRE', week=2)
>>> for game in games:
... print game
...
NYJ (13) at WAS (15)
PIT (34) at GB (51)
PHI (20) at NE (37)
KC (28) at ATL (14)
MIA (20) at CAR (27)
BUF (19) at CLE (17)
NYG (30) at DET (17)
ARI (20) at NO (15)
CIN (21) at DAL (13)
CHI (24) at DEN (23)
SF (13) at HOU (16)
SEA (14) at LAC (24)
OAK (15) at LA (19)
JAX (14) at MIN (10)
TB (30) at TEN (14)
>>> |
Hello, we have a forked version of this project setup here. You are welcome to try out our new alpha release which includes some fixes to get nflgame. Including some usability fixes which should help with this exact issue.
|
Does nfldb work with the forked version? |
I have not tested this but nflgame-redux should be a drop in replacement in nfldb. maybe @ochawkeye can speak to this. However, you should have no problems but will need to manually install the nflgame-redux repository somehow. Easiest would probably be forking and changing setup.py to reference nflgame-redux. I am considering forking all of the nfl* code but I am undecided and need to reach out ot more contributors across the projects. |
Yes, this fork of S:\>python
Python 2.7.14 (v2.7.14:84471935ed, Sep 16 2017, 20:19:30) [MSC v.1500 32 bit (Intel)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import nfldb
>>> db = nfldb.connect()
>>> q = nfldb.Query(db)
>>> q.game(season_year=2018, season_type='Preseason')
<nfldb.query.Query object at 0x020E4410>
>>> for game in q.as_games():
... print game
>>>
|
@ochawkeye - This was SEMI intentional (as the project ocupies the same namespace).... however I've not tested how pip resolves requirements like this extensively. Does it matter what order you install them in? |
The two cannot coexist. pip didn't make any effort to resolve the conflict in names. Every file in the \site-packages\nflgame directory was replaced with its counterpart in the
If one were to In my mind I would have Probably not a huge deal since this fork serves as the normal evolution of the old nflgame, but does strike me as a big |
Ehhh I, not so passionately, disagree with import nflgame-redux as nflgame. Keeping the same namespace is something i've seen other revival forks do when it is intends to pick up a dead or dying project and, for me personally, is 100% desired. In an ideal situation we gain enough traction for the fork to get acknlowedged and replace the entire pypi listing and existing repository to us. Or some version of events similar to that. |
Also this needs to be clearly documented to avoid the situation I put you in. |
How to update schedule so that it includes 2018 games?
Shouldn't nflgame.update_sched.run() work?
The text was updated successfully, but these errors were encountered: