Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2018 Postseason and Super Bowl Issues Documented and explained #373

Open
arnm opened this issue Feb 7, 2019 · 7 comments
Open

2018 Postseason and Super Bowl Issues Documented and explained #373

arnm opened this issue Feb 7, 2019 · 7 comments

Comments

@arnm
Copy link

arnm commented Feb 7, 2019

https://www.youtube.com/watch?v=6Y0cBnlee2Y

@mickeelm
Copy link

mickeelm commented Feb 7, 2019

This project has been unmaintained for almost a year. There is an active fork (not super active at the moment but that might change) where for instance I have contributed some fixes.

https://github.com/derek-adair/nflgame

I very briefly checked the video but it seemed like a fun thing :) Anyhow, I think you talked about it briefly (really just jumped through parts) but this project does not work with Python3 unfortunately. There is an open issue about it in the fork though.

EDIT: Exactly a year today, actually :)

@arnm
Copy link
Author

arnm commented Feb 7, 2019

@mickeelm Thanks for the heads up! I was not aware of the active fork

@BurntSushi
Copy link
Owner

@arnm Nice video! Thanks for the kind words too. :-)

@mickeelm @derek-adair If you want to submit a PR to the nflgame README, I'd be happy to add a link with the "unmaintained" message. Keeping a fork active for a year is good enough for me. :-)

@mickeelm
Copy link

mickeelm commented Feb 8, 2019

@BurntSushi Actually, it was this project's "unmaintainment" that had an anniversary, the fork has been around since some time around the season opener, IIRC. But I believe it is the "unofficial official fork" of nflgame, haven't seen any other at least, so I hope that's good enough :) PS. If you're still curious about NFL's data sources for other projects or whatnot, this issue might be of interest.

@derek-adair I think it's great if you are the one submitting such a PR (if you still intend to maintain the fork, I know you've been busy) :)

@derek-adair
Copy link
Contributor

@BurntSushi - i'm definitely committed at this point. Very happy to have earned your blessing! I will get a PR over to you today.

Just an FYI - I have scheduled plans to bring the rest of @BurntSushi 's hard work under one (maintained) roof. I still don't have any set plans, but I am considering combining some or all of these tools into one configurable namespace. At a minimum it would serve to unite the github issues, there seem to be a lot of cross-posting.

This will take place some time around end of Q1. Stay tuned!!

@derek-adair
Copy link
Contributor

OMFG @arnm!!!!!!! i just watched that youtube video. Awesome project.

@cmjarrett
Copy link

Really funny video. Hoping to help derek et al once I become a bit more familiar with the code-base and python.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants